vulkan-renderer icon indicating copy to clipboard operation
vulkan-renderer copied to clipboard

[cmake] Add windows resource file for application icon and metadata

Open IAmNotHanni opened this issue 4 years ago • 6 comments

Closes https://github.com/inexorgame/vulkan-renderer/issues/382 Closes https://github.com/inexorgame/vulkan-renderer/issues/420

  • [x] Rework this pull request after https://github.com/inexorgame/vulkan-renderer/pull/329 is merged.

metadata

TODO

  • [x] Switch language to English
  • [x] Do we really need resource.hpp?
  • [x] Add Git SHA to application's metadata
  • [x] Ignore resource file in CMake on Linux to fix build
  • [x] Ask @IceflowRE for help

IAmNotHanni avatar May 03 '21 20:05 IAmNotHanni

Alright I'm ready for review :+1:

IAmNotHanni avatar Jul 19 '21 22:07 IAmNotHanni

I will include the following fix in meta.hpp.in

#ifndef NDEBUG
constexpr const char *BUILD_TYPE = "Debug";
#else
constexpr const char *BUILD_TYPE = "Release";
#endif

This will also fix https://github.com/inexorgame/vulkan-renderer/issues/420

IAmNotHanni avatar Jul 21 '21 22:07 IAmNotHanni

Will review the rest later.

IceflowRE avatar Jul 22 '21 15:07 IceflowRE

I rebased onto master.

IAmNotHanni avatar Jul 28 '21 17:07 IAmNotHanni

There's a problem with this code. The binary does not contain all the information I want to be in there:

grafik

IAmNotHanni avatar Aug 01 '21 23:08 IAmNotHanni

There's a problem with this code. The binary does not contain all the information I want to be in there:

grafik

Will take a look today.

IceflowRE avatar Aug 02 '21 02:08 IceflowRE