vulkan-renderer icon indicating copy to clipboard operation
vulkan-renderer copied to clipboard

Use taskflow for concurrency

Open IAmNotHanni opened this issue 5 years ago • 4 comments

Doing multithreading correctly is a tricky business. We don't have to reinvent he wheel on that one. As we discussed earlier, we will remove our own threadpool implementation (which was very easy to deadlock) and use taskflow instead.

IAmNotHanni avatar Aug 04 '20 10:08 IAmNotHanni

There is a conan package for it: taskflow/2.5.0 .

IAmNotHanni avatar Aug 04 '20 10:08 IAmNotHanni

The simple implementation of our own thread-pool thingy was already removed here: 62455b499385f8d182d6090ad4ef88bdb0095225

IceflowRE avatar Aug 15 '20 22:08 IceflowRE

@IAmNotHanni I noticed this message - please don't hesitate to let me know if anything we can help you in porting taskflow (https://taskflow.github.io/) - :)

tsung-wei-huang avatar Aug 23 '20 05:08 tsung-wei-huang

@tsung-wei-huang Wow I just noticed your reply now! Amazing thank you!

IAmNotHanni avatar Aug 31 '20 14:08 IAmNotHanni