inexorabletash
Sector data contains invalid / misspelled / unknown allegiance codes
Sector data contains a lot of invalid / misspelled / unknown allegiance codes. In surveys this leads to a not complete Alleg section in metadata.
Expectation is, that used codes in a sector's world data should be displayed as allegiances in Alleg section in sector data. As far as I can see, this is exactly your implementation.
Types of invalid codes are different. Sometimes these are simply misspelled wrt casing. Others are completely unknown and not defined in related sector xml. In a different case, allegiance code is different from the one in 'allegiance_code.tab' (e.g. Nx and NaXX). In the latter case generally known code should be used.
Examples:
- Typo: IN should be In
- Typo: Cc should be Cr
- Missing unknown allegiances: SI, DC, PA, TC
- Wrong code: Nx instead of NaXX
This pull request fixes all the above in most of the existing sector data.
I've been going through and fixing several of these c/o some updated tooling. Ones that will require more research and/or contacting the author to determine intent:
Faraway:
- Ares - multiple
- Far Home - Ns
- Marischal - JD
M1105:
- Fulani - Nav
- Harea - Nx, Ns, NX
- Holowon - He
- Numbis - J1
- Phlange - EC
M1120:
- Lishun - Cv
M1201:
- Reft - TB
- Spica - H1
- Windhorn - Ts
- Zarushagar - Vc
M1248:
- Gvurrdon - Cc
- Massilia - Gc
That last revision updates:
Faraway / Far Home - define Ns M1105 / Fulani - fix Nav to NaXX M1105 / Harea - fix NX to Nx, define Ns/Nx