text-encoding icon indicating copy to clipboard operation
text-encoding copied to clipboard

Remove require of encoding-indexes.js

Open arv opened this issue 8 years ago • 4 comments

Right now encoding-indexes.js is always required in a node like environment (such as browserify).

This was done in a85ce6ff385b71a9cafdad46cb6965ff3bd2de36

It would be better if encoding-indexes.js was never implicitly included.

arv avatar Nov 17 '15 00:11 arv

Suggestions (or PRs) appreciated. I want to keep things testable out of the box (i.e. runnable via gh-pages) but otherwise I'm amenable to pretty much anything.

inexorabletash avatar Nov 17 '15 03:11 inexorabletash

Something with this that would allow selective inclusion of different encodings would be good for us. We are only interested in UTF-8 and build using webpack, but we end up with all encodings getting bundled.

Not sure what the best option might be..

cgwyllie avatar Mar 18 '16 13:03 cgwyllie

Again, happy to do this but I am unfamiliar with these environments and so guidance is needed.

inexorabletash avatar Oct 24 '16 17:10 inexorabletash

Yes I am experiencing the same thing - using web pack to build and don't want indexes.. great polyfill tho

surfjedi avatar Nov 28 '17 18:11 surfjedi