IXP-Manager icon indicating copy to clipboard operation
IXP-Manager copied to clipboard

Fix to #829

Open agbcix opened this issue 2 years ago • 1 comments

[BF] Unconditionally re-initialize sFlow collector counters - fixes inex/IXP-Manager#829

Previously the counters were not reset in case the API was unreachable. After writing data to RRDs new counters need to be initialized unconditionally.

In addition to the above, I have:

  • [x] ensured all relevant template output is escaped to avoid XSS attached with <?= $t->ee( $data ) ?> or equivalent.
  • [x] ensured appropriate checks against user privilege / resources accessed
  • [x] API calls (particular for add/edit/delete/toggle) are not implemented with GET and use CSRF tokens to avoid CSRF attacks

agbcix avatar May 17 '23 07:05 agbcix

I've had a look at this, but fixing this properly is likely to be more complicated than this patch, e.g. startup considerations, etc. I'll have another look before working out what the best approach is

nickhilliard avatar May 23 '23 11:05 nickhilliard