tcpproxy icon indicating copy to clipboard operation
tcpproxy copied to clipboard

Refactored the test files with helpers to test backend

Open yangchenyun opened this issue 6 years ago • 3 comments

Refactored the test by extracting the following two methods:

func testRouteToBackend(t *testing.T, front net.Listener, back net.Listener, msg string)
func testNotRouteToBackend(t *testing.T, front net.Listener, back net.Listener, msg string) <-chan bool

This change is Reviewable

yangchenyun avatar Apr 11 '18 01:04 yangchenyun

Ping for a look.

yangchenyun avatar Apr 20 '18 08:04 yangchenyun

ping?

yangchenyun avatar Oct 10 '19 00:10 yangchenyun

The returned channel is weird.

And the helpers are both undocumented.

What's the point of this? The PR just says it's "refactored" ... but why?

bradfitz avatar Oct 10 '19 04:10 bradfitz