tcpproxy icon indicating copy to clipboard operation
tcpproxy copied to clipboard

Enable add/remove routes after server starts

Open yangchenyun opened this issue 6 years ago • 6 comments

  • Use a map instead of slice to hold routes for each configuration
  • Issue a serial number for the route added in order to remove them later
  • Ensure Add/RemoveRoute is thread-safe by using a lock to guard write to the routes, because each write to router has its own serial number, racing condition only exists during registration. The lock should have minimal affect during serving.

Also added two test helpers to simplify and complete existing tests:

func testRouteToBackend(t *testing.T, front net.Listener, back net.Listener, msg string) 
func testNotRouteToBackend(t *testing.T, front net.Listener, back net.Listener, msg string) <-chan bool

yangchenyun avatar Apr 07 '18 07:04 yangchenyun

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

googlebot avatar Apr 07 '18 07:04 googlebot

I signed it!

yangchenyun avatar Apr 07 '18 07:04 yangchenyun

CLAs look good, thanks!

googlebot avatar Apr 07 '18 07:04 googlebot

All the renamings in this PR obscure the actual change you're trying to make.

Can you split your changes into two parts, or refrain from renames for now?

bradfitz avatar Apr 10 '18 19:04 bradfitz

I separated the test refactoring in a #16, and I would do rebase and squash after that is check in.

yangchenyun avatar Apr 11 '18 01:04 yangchenyun

Adding routes only works for an already registered ipPort. The stuff in done in tcpproxy.Start() - looping over configs and calling p.netListen() is not done again.

For removal of a route, it would be nice to cancel onging connections for this route. This would require a map or list of ongoing connections for a route

georgmu avatar Sep 06 '18 09:09 georgmu