inet icon indicating copy to clipboard operation
inet copied to clipboard

Published 20 hours ago • verified publisher icon inet-framework

[TSN feature] Ieee8021qTimeAwareShaper and PeriodicGate

Open yue2388253 opened this issue 3 years ago • 2 comments

  • Ieee8021qTimeAwareShaper: added GateControlList, a module which accepts parameters in GCL format and configures the corresponding PeriodicGate modules.
  • PeriodicGate: provide a parameter to configure whether the implicit guard band feature is enabled.

yue2388253 avatar Jun 29 '22 03:06 yue2388253

Resolves #774 and #775

yue2388253 avatar Jun 29 '22 03:06 yue2388253

Thanks for the PR and sorry for the delay, I was on holiday.

I think the additional parameter in the PeriodicGate module can be merged as it is.

As for the GateControlList submodule I'm not sure. It is generally correct, but I think this submodule should be optional, becuase the gate submodule types can be changed to anything. Also, in the case of automatic gate schedule configuration, the GateControlList submodule is not used and thus it would be confusing if not wrong to have it. I'm not sure if the GateControlList submodule should be used by default in the example. I kinda understand the reason is that you wanted to make the example more standard compliant, so I can be convinced about this.

levy avatar Jul 04 '22 08:07 levy

This pull request has been merged into master with some changes:

  • examples/showcases are not modified
  • the GateControlList module is not present in the Ieee8021qTimeAwareShaper by default, it must be requested using hasGcl

levy avatar Mar 06 '23 09:03 levy