inet - version 2.2.0 TCP Vegas bug

Open sariel86 opened this issue 10 years ago • 4 comments

Hi,

There is a bug in inet version 2.2.0 regarding TCPVegas algorithm.

File : src/transport/tcp/flavours/TCPVegas.cc

When reaching congestion avoidance and deciding on TCP cwnd incr/decr (checking if diff<2 or diff>4) , this check should be every ack and not every RTT.

This is also the implementation in Linux Kernel.

Best, Sariel.

Mar 28 '15 17:03 sariel86

Apparently also present in 2.6 and 2.99. Sariel, thanks for reporting! If you happen to have a fix already, it would be very welcome.

Mar 29 '15 11:03 avarga

Not yet.

If I will have the fix I will submit it.

Best, Sariel.

Mar 29 '15 11:03 sariel86

Great, thanks!

Mar 29 '15 11:03 avarga

Has this bug been fixed?

The mentioned

(checking if diff<2 or diff>4)

is done here (for <2). Some lines above, here, the following is checked:

if (newRTT > 0) {

Thus, maybe the desired

this check should be every ack and not every RTT.

is accomplished and the bug has been fixed?

Apr 11 '17 20:04 seekM