inertia icon indicating copy to clipboard operation
inertia copied to clipboard

[react] store transform callback in useRef

Open mrmonat opened this issue 3 years ago • 1 comments

This should fix #1131

I think because the old implementation did not persist the callback between renders, the transform method of the form helper had no effect (was reset to default (data) => data callback) when called like shown in the example in issue #1131

mrmonat avatar May 05 '22 11:05 mrmonat

I ran into the same issue and can confirm that this fixes the issue.

mxmtsk avatar May 24 '22 20:05 mxmtsk

Can we please put priority on this pull request? It's not great the documented transform feature just 100% does not work at all for this long with an active fix available

ashlimx avatar Nov 08 '22 17:11 ashlimx

Is there no update on this PR?

mahangm avatar Dec 09 '22 00:12 mahangm

This looks like it needs rebasing as it has a bunch of other unrelated changes in it

Jamesking56 avatar Feb 04 '23 23:02 Jamesking56

This is a huge update! Can confirm this is working as expected. How can we get this merged? These are the only changes which are needed:

https://github.com/inertiajs/inertia/pull/1171/commits/53b40db1beaef3b366ad738de1c956572e1b1c69

ghost avatar Feb 25 '23 07:02 ghost

#1491 is newer.

mrmonat avatar Jun 02 '23 14:06 mrmonat