inertia-laravel icon indicating copy to clipboard operation
inertia-laravel copied to clipboard

Published 20 hours ago • verified publisher icon inertiajs

[2.x] Revert IDE helpers

Open ycs77 opened this issue 1 year ago • 1 comments

Relation PR: #654, #674

Because IDE helpers caused trouble, so revert #413 and #625.

The above Illuminate\Testing part of the IDE helpers was created by @claudiodekker, I'm not the author, so I didn't remove it.

ycs77 avatar Oct 13 '24 07:10 ycs77

Hope this gets merged - it's small, but a great QOL change

SamMakesCode avatar Oct 17 '24 12:10 SamMakesCode

@ycs77 please merge it

siarheipashkevich avatar Mar 12 '25 09:03 siarheipashkevich

I can't merge it because I'm not the maintainer, I do not have permission.😭

ycs77 avatar Mar 12 '25 13:03 ycs77

@taylorotwell @joetannenbaum could you merge this PR and https://github.com/inertiajs/inertia-laravel/pull/654, https://github.com/inertiajs/inertia-laravel/pull/674?

ycs77 avatar Mar 12 '25 13:03 ycs77

Sorry, what trouble are they causing?

joetannenbaum avatar Apr 10 '25 15:04 joetannenbaum

Sorry, what trouble are they causing?

Since I released the IDE helper update (#413, #625) before, many users have reported that the IDE IntelliSense is broken (https://github.com/inertiajs/inertia-laravel/pull/625#issuecomment-2131961810, #654), although they don't use IDE helper, so this PR will revert the PRs that caused the problem.

Regarding the PR #674 and #654 on the 1.x branch, I think merging it will fix this issue for the users to using 1.x, it just removes the IDE helper file, will not modify any current features, @joetannenbaum can you consider merging it?

ycs77 avatar Apr 10 '25 16:04 ycs77

Then I add some changes about these PRs:

  • #654
    • Ignore export _ide_helpers.php in .gitattributes
  • #674
    • Remove IDE helpers with my added
  • #675 (current PR)
    • Ignore export _ide_helpers.php in .gitattributes
    • Remove IDE helpers with my added

If ignore export _ide_helpers.php in .gitattributes, then will not download the _ide_helpers.php in running composer require.

ycs77 avatar Apr 11 '25 07:04 ycs77

I'd love to see this fix get merged!

@ycs77 I appreciate you working on this!

BeingTomGreen avatar May 01 '25 20:05 BeingTomGreen

I have to investigate a little bit further, but perhaps it's fine to remove _ide_helpers.php from the repository at all. Other Laravel packages that provide macros also don't come with this file.

pascalbaljet avatar Jun 04 '25 11:06 pascalbaljet

I think it's safe to say we can remove the file. If you want this behavior, you can either use the IDE Helper package (works both in PhpStorm and VS Code) or the Laravel Idea plugin for PhpStorm.

pascalbaljet avatar Jun 05 '25 20:06 pascalbaljet

@pascalbaljet I have removed the file. Could you review this PR and PR #740 from 1.x ?

ycs77 avatar Jun 06 '25 04:06 ycs77

@pascalbaljet I have removed the file. Could you review this PR and PR #740 from 1.x ?

Yes, I saw that, thanks! I've updated the 1.x branch so that the tests work again on GitHub Actions. Gonna do some final checks, and then I'll merge both at the end of the day.

pascalbaljet avatar Jun 06 '25 08:06 pascalbaljet