git-master
git-master copied to clipboard
ineo6
Stopped working at GitLab
Describe the bug On GitLab, the addon stays entirely dormant, claiming it has no internet access ("You have to be connected to the Internet"). On Github it claims the same, but at least the functionality is still there (the browser pane is available) – same on Gitea instances.
To Reproduce Steps to reproduce the behavior:
- install the addon
- visit GitLab, Github, Codeberg…
Expected behavior No such message, but the usual selection list being shown when tapping the icon from the toolbar – and the browser pane being available at GitLab as well.
Screenshots
Context (please complete the following information):
- Platform(GitHub, GitLab, Gitee, Gitea): all, with GitLab being most affected
- Browser and Version: Waterfox Classic, Waterfox G3 (both in their latest version)
- GitMaster Version: 1.17.0, but it started out-of-the-blue with 1.16.1
Additional context The issue started out-of-the-blue with the addon working fine yesterday (still being on 1.16.1). An update to 1.17.0 didn't solve it. I suspect the URL you use to check internet activity might have been caught by some blacklist – but that would not explain why it partly works on Github and Gitea (with the pane working fine) but stopped entirely for GitLab. As I don't know how you check, I cannot verify.
Am I the only one with this issue (which still persists with 1.17.1), or can someone confirm?
Work fine for me(classic).
The message you see belongs to GitHub Notification feature, so you can check 'Preferences' page.
- "Root URL": default is 'https://api.github.com/' if not Enterprise user
- "Token": You can create one if empty
Work fine for me(classic).
For GitLab? Fails for me with Classic and G3 (no sidebar). All others (Gitea, Github) work fine. And if that message just concerns Github notifications, I can simply ignore it, thanks :wink:
Attention!
When you visit gitlab.com by Classic version(G3 maybe also), there is an error:"ReferenceError: customElements is not defined".
I think the reason is Classic or G3 too old, try latest version G4.
As it worked before, it's either a change at GitLab breaking compatibility (wouldn't be the first) or in the addon. I guess it's the former, as it happened out of the blue and not "right after an update". And no, changing the browser is not an option. I don't have time to configure another browser all few weeks just because some devs (here: at GitLab) think they need to implement some crazy stuff just because they can – as said, this is not the first time (and wouldn't be the first time they had to revert things as they broke compatibility).
Besides: Console output here (in G3) ends one line earlier, with the apis.google.com line.
Currently it's working fine. Just with Waterfox G4 it always forgets the Github API token (keeps it fine in classic). Any idea what that could be?
Updated to G5. Access token still forgotten regularly. Wish I knew where to check or how to fix that. Oh, maybe it's related to this one :scream: I've disabled the LocalStorage part of it and will see if that helps.
The access token being forgotten was indeed the linked reason (and long solved for me). But GitLab again stopped working for me; latest Waterfox G6 here meanwhile. Still hoping you will pick up development again one day, @ineo6 – and hopefully find out what is behind this. Looking forward to an update. Unfortunately I'm not familiar with TS and addon development or I had checked myself. None of the forks has something either…