Added get_mix_inverter_settings to retrive data

[LasseBang]

Added get_mix_inverter_settings to retrive data such at time for discharge/charge

[muppet3000]

Please can you update the readme.md file to add information about the new function and how to use it (we have this for all of the other functions)?

[LasseBang]

Please can you update the readme.md file to add information about the new function and how to use it (we have this for all of the other functions)?

Done :-)

[AnonTester]

Please merge this. Very useful PR.

[LasseBang]

indeed!

[LasseBang]

Hi,

yes your change looks right 😊

Fra: indykoning @.> Dato: søndag, 13. august 2023 kl. 19.56 Til: indykoning/PyPi_GrowattServer @.> Cc: Lasse Bang @.>, Author @.> Emne: Re: [indykoning/PyPi_GrowattServer] Added get_mix_inverter_settings to retrive data (PR #59)

@indykoning commented on this pull request.

I was going to merge this in but just want to check one small thing if the indenting is correct here

---

In growattServer/init.pyhttps://github.com/indykoning/PyPi_GrowattServer/pull/59#discussion_r1292832656:

@@ -669,3 +669,23 @@ def update_ac_inverter_setting(self, serial_number, setting_type, parameters):

     }

     return self.update_inverter_setting(serial_number, setting_type,

                                         default_parameters, parameters)

•    def get_mix_inverter_settings(self, serial_number):
  

The indenting looks off, so a sanity check. Isn't this the right indenting? ⬇️ Suggested change

•    def get_mix_inverter_settings(self, serial_number):
  

• def get_mix_inverter_settings(self, serial_number):

---

In growattServer/init.pyhttps://github.com/indykoning/PyPi_GrowattServer/pull/59#discussion_r1292832948:

•    def get_mix_inverter_settings(self, serial_number):
  

•    """
  

•    Gets the inverter settings related to battery modes
  

•    Keyword arguments:
  

•    serial_number -- The serial number (device_sn) of the inverter
  

•    Returns:
  

•    A dictionary of settings
  

•    """
  

•    default_params = {
  

•        'op': 'getMixSetParams',
  

•        'serialNum': serial_number,
  

•        'kind': 0
  

•    }
  

•    settings_params = {**default_params}
  

I see this is not used, probably a leftover ⬇️ Suggested change

•    settings_params = {**default_params}
  

— Reply to this email directly, view it on GitHubhttps://github.com/indykoning/PyPi_GrowattServer/pull/59#pullrequestreview-1575870439, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AG5V2R6BCE5RCYEHXE57BWDXVEILRANCNFSM6AAAAAAVXWFKDE. You are receiving this because you authored the thread.Message ID: @.***>