python-build-standalone icon indicating copy to clipboard operation
python-build-standalone copied to clipboard

Published 20 hours ago • verified publisher icon indygreg

Ensure that Hacl_Hash_SHA2 does not appear as a library to link to

Open ntamas opened this issue 1 year ago • 4 comments

When trying to update PyOxidizer and PyOxy to support standalone builds of Python 3.12, I noticed that the build attempted to link to a library named Hacl_Hash_SHA2 when pyoxy was linked (with -lHacl_Hash_SHA2). This PR fixes the metadata in PYTHON.json.

ntamas avatar Sep 01 '24 23:09 ntamas

Can you share a diff of the PYTHON.json metadata?

zanieb avatar Sep 06 '24 03:09 zanieb

Sure! I'm attaching two diffs here; full.diff was generated with diff -u, but it contains lots of lines where the only difference is in the names of the temporary folders where the build was executed. relevant.diff was created manually from full.diff by deleting those chunks where the only difference was the name of the temporary folder so you can see the differences more clearly.

Both diffs are attached in a ZIP file here: diffs.zip

ntamas avatar Sep 06 '24 09:09 ntamas

Thanks! The change in the metadata makes sense to me but I don't fully understand why it was written this way in the first place?

zanieb avatar Sep 09 '24 11:09 zanieb

I don't know either -- maybe @indygreg remembers? I think he was the one who initially wrote the code for supporting Python 3.12 where the pre-3.12 hash functions were replaced with implementations from HACL*.

ntamas avatar Sep 09 '24 12:09 ntamas