asn1.js icon indicating copy to clipboard operation
asn1.js copied to clipboard

Code is currently checking bn.sign but should be bn.negative

Open satazor opened this issue 5 years ago • 0 comments

https://github.com/indutny/asn1.js/blob/b99ce086320e0123331e6272f6de75548c6855fa/lib/asn1/encoders/der.js#L201

Shouldn't this be bn.negative instead of bn.sign? It seems that bn.sign was available in [email protected] but was renamed in recent versions.

Can you confirm if this is the case? If so, I can make a quick PR to fix it.

satazor avatar Mar 21 '19 18:03 satazor