pymbolic icon indicating copy to clipboard operation
pymbolic copied to clipboard

Test missing assertions

Open iandinwoodie opened this issue 1 year ago • 3 comments

The following test doesn't seem to be making any assertions about expected behavior:

https://github.com/inducer/pymbolic/blob/13e83df783d00a74b0d13d690f8f96d806646e13/test/test_pymbolic.py#L85-L94

iandinwoodie avatar May 01 '23 01:05 iandinwoodie

Similarly, the following test seems to log a response but not make any assertions about it:

https://github.com/inducer/pymbolic/blob/13e83df783d00a74b0d13d690f8f96d806646e13/test/test_pymbolic.py#L372-L385

iandinwoodie avatar May 01 '23 01:05 iandinwoodie

Thanks for reporting these. Contributions to address these would be very welcome.

inducer avatar May 02 '23 20:05 inducer

@inducer will do!

iandinwoodie avatar May 02 '23 20:05 iandinwoodie