meshmode icon indicating copy to clipboard operation
meshmode copied to clipboard

Make it clearer that `default_simplex_group` is not for external use

Open inducer opened this issue 3 years ago • 1 comments

By deprecating it and adding an underscored version.

By "definition", the function is not precise about what local discretization is chosen, which is a bad idea for code that expects consistent results run-to-run. It's currently used in mirgecom here:

https://github.com/illinois-ceesd/mirgecom/blob/0a43d11bdf5a21552a875636d8e5cefe23f76ab7/mirgecom/discretization.py#L59-L60=

and its use has also leaked into some grudge examples.

cc @MTCam @lukeolson

inducer avatar Jun 24 '22 17:06 inducer

Woops! I'll clean that up in this next PR. I stumbled on that function and thought it looked great because it would continue working even without the recursivenodes package.

fwiw, @lukeolson flagged this change in his review and I was able to convince him it was OK. Regardless, here's the "fix" in mirgecom... https://github.com/illinois-ceesd/mirgecom/pull/692/commits/be86451fc3ea8dfce8e0ad0e708727894611ed89

MTCam avatar Jun 24 '22 20:06 MTCam