loopy icon indicating copy to clipboard operation
loopy copied to clipboard

Fix CInstruction in calculating mem access map.

Open sv2518 opened this issue 1 year ago • 1 comments

I don't know if we should calculate something from the predicates or do you think this is sufficient?

sv2518 avatar Jul 18 '22 13:07 sv2518

Thanks for the patch, L(almost)GTM!

I don't know if we should calculate something from the predicates or do you think this is sufficient?

Doing something similar to get_op_map would be better i.e. counting the accesses in the predicates and emitting a warning for the uncounted accesses in CInstruction's predicates.

kaushikcfd avatar Jul 18 '22 15:07 kaushikcfd

This ultimately did go in as #765, albeit without the requested safeguards. Not the end of the world, I guess.

inducer avatar May 17 '23 22:05 inducer