Baader SteelDrive2 Sync issue

[gnthibault]

Describe the bug I have been using the driver in an automated workflow where I use the fantastic auto-homing feature of the steeldrive (+ steeltrack). Unfortunately, I realized, that while doing so, I was also forcing a focuser "SYNC" to 2000 step absolute position, which seems to be the default. But I soon realized that everytime I was doing a auto-home + sync, then my focus was moving inward by about 50 or 100 steps approximately. It seems that performing the sync through the driver is not needed, because by default Baader steeldrive always set position to 2000. Unfortunately, setting the "sync" had also a detrimental effect, and actually changes something (what, I don' t know yet, I need to crosscheck) which is not expected. I suspect there is a bug in the serial command defined here: https://github.com/indilib/indi/blob/52a9564a816d65b142b4ffd607e3fdfb1e664dc8/drivers/focuser/steeldrive2.cpp#L346

I will crosscheck in the baader documentation. Second point, I also tried to perform factory reset, but everytime I click the button, I get

[WARNING] Click button again to confirm factory reset.

Even if I click twice, I still get prompted with the same message, hence I am not sure what is going on By looking at the code it seems to be here: https://github.com/indilib/indi/blob/52a9564a816d65b142b4ffd607e3fdfb1e664dc8/drivers/focuser/steeldrive2.cpp#L221C21-L221C42

I suspect the part where m_ConfirmFactoryReset is set to true is nowhere to be found, I can potentially do a MR to correct for that if I have time, but I' d like to fix both issues at once, and have confirmation that my understanding is correct.

Thank you in advance for your help

[gnthibault]

Baader steeldrive technical documentation. According to the protocol, nothing seems to be wrong with the SET POS:XXX statement, apart maybe the fact that an uint32 is expected even though the serial protocol expects int, so I don't, know what would happen with negative value input.

steeldrive_ii_technical_documentation (1).pdf

[knro]

You're correct, the flag should be set to true after that message. If you have a PR ready, please submit!

[knro]

@gnthibault Any update?

[github-actions[bot]]

This issue has been inactive for 60 days and is being marked as stale.

[github-actions[bot]]

This issue has been closed due to inactivity.