indi icon indicating copy to clipboard operation
indi copied to clipboard

Bugfix: update focuser temperature in alluna tcs2 driver

Open peter-englmaier opened this issue 1 year ago • 3 comments

I noticed, that the focuser temperature was not updated in kstars and other clients. The reason was, that the .apply() method was not called when reading new values from the device.

Other (minor) changes:

  • update temperature more often (every 10 seconds instead of once every 5 minutes)
  • update fan speed less frequently (very 30 seconds instead of every 3 seconds)
  • corrected the copyright message in the header file to reflect my authorship (getting it in sync with the source file).

peter-englmaier avatar Apr 27 '24 12:04 peter-englmaier

Thank you @peter-englmaier can you please check the MacOS errors?

knro avatar Apr 27 '24 12:04 knro

@knro: This seems to be quite deeply rooted in indi. I have not touched any code near that.

It seems, on a mac, the 1-bit wide field 'ok' is interpreted as a signed integer. So instead of sp->ok = 1 one needs to set sp->ok = -1, however I rather would change the type to unsigned. With this the error is gone, but instead it fails for some other reason. Perhaps something has changed with the macos compiler defaults?

peter-englmaier avatar Apr 27 '24 15:04 peter-englmaier

@knro I do not grasp why the MacOS build fails. The compiler complains about missing function prototypes, but those are clearly present at the beginning of the source code:

static int compile(int prec);
static int execute(double *result);
static int parse_fieldname(char name[], int len);

Can you please help?

peter-englmaier avatar Apr 27 '24 16:04 peter-englmaier

Yes sorry, hopefully the issue is now fixed. I'm running the builds again.

knro avatar May 01 '24 06:05 knro

@knro Ok, I see you have committed some changes. I try to rebase and see if it compiles again.

peter-englmaier avatar May 04 '24 09:05 peter-englmaier

Looks like my merge has messed things up, I should probably start from scratch...

peter-englmaier avatar May 04 '24 09:05 peter-englmaier

I hope #2055 is going to compile... it is rebased on the latest master

peter-englmaier avatar May 04 '24 09:05 peter-englmaier

This PR is replaced by #2055, so I am closing it.

peter-englmaier avatar May 04 '24 09:05 peter-englmaier