indi icon indicating copy to clipboard operation
indi copied to clipboard

Enable nframe support regardless of orientation of device and set default steps/degree

Open mads0100 opened this issue 3 years ago • 7 comments

Change the phase wires from 2 to 5 in order enable full control. Change the default steps/degree from 1000 to 55 per dev guidance.

mads0100 avatar Mar 05 '22 19:03 mads0100

Submitted an update to it.

mads0100 avatar Mar 05 '22 20:03 mads0100

Thanks. Submitted an update where?

knro avatar Mar 05 '22 21:03 knro

Github. It’s my first time.

Sent from my iPhone

On Mar 5, 2022, at 15:57, Jasem Mutlaq @.***> wrote:

 Thanks. Submitted an update where?

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

mads0100 avatar Mar 05 '22 22:03 mads0100

Got a link to the PR? I don't see it.

knro avatar Mar 05 '22 22:03 knro

https://github.com/mads0100/indi

I don’t think I did this right.. it’s the nframe.cpp that needed to be updated per Gene.

Sorry.

Sent from my iPhone

On Mar 5, 2022, at 16:21, Jasem Mutlaq @.***> wrote:

 Got a link to the PR? I don't see it.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

mads0100 avatar Mar 05 '22 22:03 mads0100

Please follow the instructions on how to submit a PR to INDI. Looking forward to the PR!

knro avatar Mar 06 '22 08:03 knro

Chris, the 'closest direction' nframe test code I sent was test code. To make it 'correct' there needs to be a switch for 'cord wrap' versus 'closest direction'. The original GIT was always cord wrap aware, the test code is always 'closest direction' path.

astrogene1000 avatar Mar 09 '22 11:03 astrogene1000

This issue has been inactive for 60 days and is being marked as stale.

github-actions[bot] avatar Apr 07 '24 02:04 github-actions[bot]

This issue has been closed due to inactivity.

github-actions[bot] avatar Apr 14 '24 03:04 github-actions[bot]