link-rel-parser-php icon indicating copy to clipboard operation
link-rel-parser-php copied to clipboard

Include cassis

Open veganstraightedge opened this issue 9 years ago • 4 comments

Or document that cassis needs to be loaded to use this library.

As far as I can tell, this line won't work unless cassis is loaded by this library or by whatever app loads this library.

https://github.com/indieweb/link-rel-parser-php/blob/master/src/IndieWeb/link_rel_parser.php#L43

veganstraightedge avatar Apr 12 '16 07:04 veganstraightedge

I think a README note should suffice for now. link-rel-parser-php was intended as code sharing, not any attempt of making something standalone

tantek avatar Apr 12 '16 07:04 tantek

@tantek: I'll leave to you.

veganstraightedge avatar Apr 14 '16 04:04 veganstraightedge

Added comments to both link_rel_parser.php and get_rel_webmention.php both explicitly documenting their dependencies on CASSIS: https://github.com/indieweb/link-rel-parser-php/blob/master/src/IndieWeb/link_rel_parser.php#L7 https://github.com/indieweb/link-rel-parser-php/blob/master/src/IndieWeb/get_rel_webmention.php#L8

tantek avatar Nov 02 '16 08:11 tantek

Probably wouldn't hurt to add that dependency to the composer.json.

lostfocus avatar Jan 02 '17 10:01 lostfocus