react-native-chart-kit icon indicating copy to clipboard operation
react-native-chart-kit copied to clipboard

RTL support

Open hiradary opened this issue 6 years ago • 20 comments

hiradary avatar Sep 28 '18 20:09 hiradary

seems like not many people are interested in this, will close it for now.

Hermanya avatar Jan 20 '19 21:01 Hermanya

Hello @Hermanya actually, there are interested people in this! I really love what you did but it's so disappointing that I can't use it in my RTL app! I need it. And I know there are millions of people that building RTL application and they need to support. So, please open this issue and do something about it. Regards, Hossein.

hrahimi270 avatar Mar 25 '19 16:03 hrahimi270

Thanks a lot, dear @Hermanya. This is my result. Screenshot_20190325-211349_hamsadehProviderApp

As you can see, the phrases are not displayed correctly. They are separated.

hrahimi270 avatar Mar 25 '19 16:03 hrahimi270

Truth be told, I have never developed RTL apps, so I'm not sure what the correct behavior is. I hope someone with more expertise in this will help out.

Hermanya avatar Mar 25 '19 16:03 Hermanya

Ok. I'll do my best to help you out 👍

hrahimi270 avatar Mar 25 '19 16:03 hrahimi270

@Hermanya I know what is the problem now. You use SVG Text and it's not supported for RTL languages! https://github.com/react-native-community/react-native-svg/issues/439 I don't know if there is a way to solve this problem or not. But I hope we find a solution to this.

hrahimi270 avatar Mar 25 '19 17:03 hrahimi270

@Hermanya

FYI, in the newer versions of react-native-svg, Tspan component supports RTL text. also, we added ForeignObject support to the library. so you may want to try the features to see if they can be useful for your chart or not.

SaeedZhiany avatar Feb 19 '20 08:02 SaeedZhiany

Thanks a lot, dear @Hermanya. This is my result. Screenshot_20190325-211349_hamsadehProviderApp

As you can see, the phrases are not displayed correctly. They are separated.

Were you able to solve this problem???

yousefshakoury avatar Nov 16 '20 15:11 yousefshakoury

Hi @yousefshakoury. At that time I decided to not use this chart and don't remember what I did exactly ((: But I think @SaeedZhiany's reply is useful to contribute to this project and give it a try to solve this issue if still exists.

Best of luck.

hrahimi270 avatar Nov 24 '20 15:11 hrahimi270

Thank you so much Mr.Hossein for your reply! Good job🙏🙏

On Tue, Nov 24, 2020 at 7:27 PM Hossein Rahimi [email protected] wrote:

Hi @yousefshakoury https://github.com/yousefshakoury. At that time I decided to not use this chart and don't remember what I did exactly ((: But I think @SaeedZhiany https://github.com/SaeedZhiany's reply is useful to contribute to this project and give it a try to solve this issue if still exists.

Best of luck.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/indiespirit/react-native-chart-kit/issues/48#issuecomment-733066402, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKFIEAGBKI44UJDFQAZI6LSRPJWVANCNFSM4FX654KQ .

yousefshakoury avatar Dec 01 '20 19:12 yousefshakoury

Thanks a lot, dear @Hermanya. This is my result. Screenshot_20190325-211349_hamsadehProviderApp As you can see, the phrases are not displayed correctly. They are separated.

Were you able to solve this problem???

I was able to solve this problem with this site : http://awebfont.ir/convert/index Just copy the output of this site somewhere And then you realize that the letters are not in order And you have to sort the letters and then put them in the code

amirbhz86 avatar Feb 07 '21 11:02 amirbhz86

Good, thank you so much! It's worked for me for static labels! Have you any idea about dynamic labels for this chart type?

On Sun, Feb 7, 2021 at 3:12 PM amirreza behrouzi [email protected] wrote:

Thanks a lot, dear @Hermanya https://github.com/Hermanya. This is my result. [image: Screenshot_20190325-211349_hamsadehProviderApp] https://user-images.githubusercontent.com/38007163/54937954-111c9600-4f43-11e9-880c-305c15a180b4.jpg As you can see, the phrases are not displayed correctly. They are separated.

Were you able to solve this problem???

I was able to solve this problem with this site : http://awebfont.ir/convert/index Just copy the output of this site somewhere And then you realize that the letters are not in order And you have to sort the letters and then put them in the code

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/indiespirit/react-native-chart-kit/issues/48#issuecomment-774659969, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKFIEDNTT4OTJ2A2NOC65DS5Z4CLANCNFSM4FX654KQ .

yousefshakoury avatar Feb 07 '21 21:02 yousefshakoury

Thanks a lot, dear @Hermanya. This is my result. Screenshot_20190325-211349_hamsadehProviderApp As you can see, the phrases are not displayed correctly. They are separated.

Were you able to solve this problem???

I was able to solve this problem with this site : http://awebfont.ir/convert/index Just copy the output of this site somewhere And then you realize that the letters are not in order And you have to sort the letters and then put them in the code

Good, thank you so much! It's worked for me for static labels! Have you any idea about dynamic labels for this chart type?

yousefshakoury avatar Feb 07 '21 21:02 yousefshakoury

Hi everyone, I need this with dynamic labels, so I can't use the awebfont.ir. Have you found a solution?

armata99 avatar May 11 '21 06:05 armata99

Hi anyone able to find any solution? #Please #Update #here

jyotiprakash111 avatar Sep 14 '21 11:09 jyotiprakash111

use this repo https://github.com/font-store/persian-reshaper to prepare RTL texts to be used in SVG Text component

amiinous avatar Sep 22 '21 18:09 amiinous

Is there a plan for RTL support ? @Hermanya

h-assefi avatar Dec 12 '21 06:12 h-assefi

I used this package. it works npm package rtl reshaper

h-assefi avatar Dec 12 '21 09:12 h-assefi

I used this package. it works npm package rtl reshaper

thank you so much you saved my life! great job bro!

MessaoudiMohammed avatar Dec 29 '23 14:12 MessaoudiMohammed