ui icon indicating copy to clipboard operation
ui copied to clipboard

Use required prop for label asterisk

Open madmax124 opened this issue 1 year ago โ€ข 2 comments

Show asterisk in label when required prop is true.

๐Ÿ”— Linked issue

โ“ Type of change

  • [ ] ๐Ÿ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • [ ] ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • [x] ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • [ ] โœจ New feature (a non-breaking change that adds functionality)
  • [ ] ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • [ ] โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

Do we need to publish a new version of a package?

  • [ ] Add a changeset pnpm changeset and select what semver changes your PR is adding
    • commit and push the generated changeset file

๐Ÿ“ Checklist

  • [ ] I have linked an issue or discussion.
  • [ ] I have updated the documentation accordingly.

๐Ÿ“š Description

madmax124 avatar Jun 10 '24 14:06 madmax124

@jpntex

madmax124 avatar Jun 20 '24 08:06 madmax124

Thank you, sorry for the delay. Awesome idea, will adapt this to a global configuration so others can opt out of the *

jpntex avatar Jul 12 '24 15:07 jpntex

Thanks @madmax124, went for the styling option, so anyone can override with custom theming: https://github.com/indielayer/ui/commit/c17ac2d96e4bca0f1215b80b3badd73fdec04edc

jpntex avatar Oct 19 '24 22:10 jpntex