cloudfish icon indicating copy to clipboard operation
cloudfish copied to clipboard

Error if domain can't be found

Open Xitro01 opened this issue 1 year ago • 1 comments

There is an error if a domain can't be found:

Traceback (most recent call last):
  File "/home/kali/Tools/cloudfish/cloudfish.py", line 149, in <module>
    records = dns.records(args.domain,args.key,args.email,args.account,verbose)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/kali/Tools/cloudfish/cloudfish.py", line 74, in records
    self.zone = create_j["result"]["id"]
                ~~~~~~~~~~~~~~~~~~^^^^^^
TypeError: 'NoneType' object is not subscriptable

Would be nicer to show an error message, that the domain could not be found.

Xitro01 avatar Dec 20 '24 21:12 Xitro01

You are totally right. My error handling back then was pretty poor. 😬 I'm super busy at the moment but if you want to write up a patch feel free to submit it as a pull request.

indianajson avatar Dec 20 '24 21:12 indianajson

Pull request accepted, apologies again for the delay on my end to accept it.

indianajson avatar Jul 11 '25 17:07 indianajson