nconf icon indicating copy to clipboard operation
nconf copied to clipboard

Modernize test framework

Open mhamann opened this issue 8 years ago • 10 comments

Convert existing vows.js based test suite to something a bit more common and well-known. This will help newer contributors understand how to write an effective test, which will lower the barrier to entry.

Potential frameworks include: ava, tap, and mocha.

mhamann avatar Oct 29 '17 01:10 mhamann

after spending some time with the test I think it's definitively a must have. Besides vows is unmaintained for years.

For frameworks I had in mind ava, jest, and mocha. The two first are the most trending theses days, and probably more jest than ava with react traction.

I would rather tend to jest because it has a describe/it nested test structure that ava does not have.

(https://stackshare.io/stackups/jest-vs-ava)

AdrieanKhisbe avatar Oct 30 '17 18:10 AdrieanKhisbe

@mhamann Shall I start to translate some of the test (some in ava, some in jest to serve as base of comparison?)

AdrieanKhisbe avatar Nov 08 '17 20:11 AdrieanKhisbe

Yep, go for it. If Jest feels like a good fit, I am fine moving forward with that. I have no real attachment to either.

mhamann avatar Nov 08 '17 20:11 mhamann

I started working on jest migration, you can see the first result there: https://github.com/indexzero/nconf/compare/master...AdrieanKhisbe:migrating-test-to-jest?expand=1

Waiting for your go @mhamann to go further. :)

AdrieanKhisbe avatar Nov 11 '17 11:11 AdrieanKhisbe

LGTM.

mhamann avatar Nov 11 '17 15:11 mhamann

Voilà I made the whole transition, tell me what you think @mhamann 😃

(by the way, did you add chance to advance on the 0.10? =) )

AdrieanKhisbe avatar Nov 12 '17 18:11 AdrieanKhisbe

@mhamann up :)

AdrieanKhisbe avatar Nov 16 '17 08:11 AdrieanKhisbe

Thanks--PR looking good. Hoping to finish reviewing by end of week. I'll also get 0.10 then as well. Sorry for the delay--life has been a bit crazy the past couple of weeks. Appreciate the reminder!

mhamann avatar Nov 16 '17 16:11 mhamann

No problem, take the time you need. and courage!! :)

AdrieanKhisbe avatar Nov 16 '17 18:11 AdrieanKhisbe

Hey @mhamann ! I hope the crazy times are fading away. Tell me if you need help on thé nconf part =)

AdrieanKhisbe avatar Nov 29 '17 21:11 AdrieanKhisbe