common-tags icon indicating copy to clipboard operation
common-tags copied to clipboard

ECMAScript support

Open Siilwyn opened this issue 4 years ago • 8 comments

Each commit has a body with some more more information about the changes. Commit (a68b0f3) drops support for Node.js 10 making it a breaking change which might be possible to include in v2? It does decrease the package size since no CommonJS build output is packed anymore. Feel free to rebase or cherry pick some of the changes!

Siilwyn avatar Jan 30 '21 16:01 Siilwyn

Codecov Report

Merging #212 (c0ce012) into master (d3f7042) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #212   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          121       121           
  Branches        31        31           
=========================================
  Hits           121       121           
Impacted Files Coverage Δ
src/TemplateTag/TemplateTag.js 100.00% <ø> (ø)
src/commaLists/commaLists.js 100.00% <ø> (ø)
src/commaListsAnd/commaListsAnd.js 100.00% <ø> (ø)
src/commaListsOr/commaListsOr.js 100.00% <ø> (ø)
src/createTag/createTag.js 100.00% <ø> (ø)
src/html/html.js 100.00% <ø> (ø)
src/id/id.js 100.00% <ø> (ø)
...c/inlineArrayTransformer/inlineArrayTransformer.js 100.00% <ø> (ø)
src/inlineLists/inlineLists.js 100.00% <ø> (ø)
src/oneLine/oneLine.js 100.00% <ø> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3f7042...c0ce012. Read the comment docs.

codecov[bot] avatar Jan 30 '21 17:01 codecov[bot]

Today I noticed that directory imports (e.g. import x from './some-dir') do not work. A full path including extension is needed to work in vanilla Node.js.

Siilwyn avatar Feb 01 '21 15:02 Siilwyn

Ready for review @fatfisz & @zspecza.

Siilwyn avatar Feb 03 '21 09:02 Siilwyn

@fatfisz friendly ping! I've been running into problems with npm 7 and using git tarballs as a workaround for using this patch instead of the published npm package. Let me know if I can help with anything.

Siilwyn avatar Jul 05 '21 14:07 Siilwyn

👋 @fatfisz hope you can find some time to review this PR soonish 🤞

Siilwyn avatar Feb 11 '22 13:02 Siilwyn

@Siilwyn repo is clearly dead. Should we simply fork the repo and re-publish on npm, with all of this merged?

damianobarbati avatar Jun 13 '22 16:06 damianobarbati

Hey thanks for the idea @damianobarbati, I did email a bit with the author and he did have intentions to merge this but was very busy. I'll look into forking soonish.

Siilwyn avatar Jun 17 '22 10:06 Siilwyn

Okay it's happening! I've created https://github.com/Siilwyn/common-tagged and intend to publish it coming week. But just before that I'd like to see if there are other alternatives perhaps, @damianobarbati do you still use this package?

Siilwyn avatar Sep 18 '22 11:09 Siilwyn