zsh-syntax-highlighting icon indicating copy to clipboard operation
zsh-syntax-highlighting copied to clipboard

Published 20 hours ago • verified publisher icon zsh-users

Add instructions on sourcing from distro package installation

Open Mario-paul opened this issue 4 years ago • 7 comments

Installed using the "Using packages" install how-to section for Ubuntu, but syntax highlighting does not work. .zshrc file obviously does not have sourcing information, and after trying all of the "source" lines from the INSTALL.md, it still doesn't work. clearly zsh-syntax-highlighting is installed somewhere different than the git installations, and those source lines won't work for the Ubuntu repo install.

Am I missing something? And if not, can the "Using packages" section be completed or cleared up?

Thanks

Mario-paul avatar Aug 15 '21 08:08 Mario-paul

You're right, we should spell that out.

In your case, see /usr/share/doc/zsh-syntax-highlighting/README.Debian.gz or dpkg -L zsh-syntax-highlighting for the path to zsh-syntax-highlighting.zsh.

Leaving this open to track the documentation change. If you'd like to propose new language for INSTALL.md, that'd be great :-)

danielshahaf avatar Aug 15 '21 13:08 danielshahaf

Hey Daniel, using your help I got it working using the Ubuntu package install. I noticed the Ubuntu package for my distro base (20.04) is extremely outdated though (0.6.0) so I'm just gonna install the latest github version using the oh-my-zsh plugin way lol.

As requested, I added the instructions to source .zshrc file on debian/based package installs on INSTALL.md file. Hope that looks good, otherwise you are free to edit my changes as you like.

Mario-paul avatar Aug 18 '21 05:08 Mario-paul

Thanks! We'll review the PR when we have a moment. (And the next release milestone issues list too, so recent work will reach distro users too...)

danielshahaf avatar Aug 18 '21 20:08 danielshahaf

Thanks! We'll review the PR when we have a moment. (And the next release milestone issues list too, so recent work will reach distro users too...)

Other than some Cinnamon themes, this is my first real contribution to a Linux project. How exciting! :)

Mario-paul avatar Aug 18 '21 21:08 Mario-paul

Oh, congratulations! I still remember my first few patches. Even that day when I reported a typo on IRC and @lgov (hi!) committed it upon the spot with "Patch by:" credit…

danielshahaf avatar Aug 20 '21 11:08 danielshahaf

@danielshahaf So this issue should be closed now? Or is there any help needed?

jnishwanth avatar Jul 06 '22 14:07 jnishwanth

@jnishwanth Reviews of #830 would be welcome. As to closing this since #830 is open, I could argue both ways.

danielshahaf avatar Jul 13 '22 15:07 danielshahaf

#830 is morally merged in 6507190.

phy1729 avatar Oct 25 '23 03:10 phy1729