zhen

Results 50 comments of zhen

> @zinking - if i can assist with this please let me know (would love to contribute if possible) feel free to pick it up here.

> "Finally, dangling delete will be removed by reconstruction instead of by file path, to benefit manifest pruning when iceberg table was scanned." I guess only partitionData and path is...

> @zinking I think you should follow the tips to sign cla I remembered I signed presto cla before. anyways, this repo doesn't look active you can just patch back.

> > I signed presto cla before > > @zinking This repository isn't managed by PrestoDB. Did you sign CLA of Trino https://github.com/trinodb/cla? ok just signed.

> @zinking would you please check the comments and update the PR? I was running this result against queries in spark. if your conclusion is right, then it means queries...

@przemekak what about other occurrences, I think I didn't have errors using that before renaming, should those be kept or changed ?

I'm not sure why this is supposed to work. doesn't seem an issue to me.

it's not really an issue, probably some suggestion for improvement