zls Broken when updating vscode-languageclient to latest version

Broken when updating vscode-languageclient to latest version

Open ryuukk opened this issue 3 years ago • 3 comments

Hello,

I'm trying to prepare zls for LSP 3.17, i updated vscode-languageclient to the latest version (8.0.1)

But then code completion is broken, something might have changed, but i don't know what, i'm not knowledgeable about npm stuff

Jun 22 '22 03:06 ryuukk

I can't reproduce this, please provide more details

Jul 11 '22 16:07 SuperAuguste

It's "fixed", well sort of, it is an issue with ranges

here the problematic code i had to comment:

https://github.com/zigtools/zls/blob/8d27b172aa8bc3df0f0ddb5f23ad520c8fa8839e/src/types.zig#L255-L258

Jul 11 '22 17:07 ryuukk

Seems like a zls issue then, but yeah, ranges are notoriously broken in zls unfortunately :(

Jul 11 '22 19:07 SuperAuguste

the LSP types are now completely auto generated and no further issues around this have been reported so I assume this is now outdated.

Feb 04 '24 22:02 Techatrix