hal_stm32 icon indicating copy to clipboard operation
hal_stm32 copied to clipboard

Published 20 hours ago • verified publisher icon zephyrproject-rtos

dts: st: h7: pinctrl.dtsi files including DCMI pins

Open CharlesDias opened this issue 1 year ago • 4 comments

Generate DCMI pins definitions for H7 family.

Related PR:

  • https://github.com/zephyrproject-rtos/zephyr/pull/71462
  • https://github.com/zephyrproject-rtos/zephyr/pull/71463

CharlesDias avatar May 06 '24 17:05 CharlesDias

Looks good to me but would it be possible to generate pins as well for other series? I know driver is H7 specific for now (at least only validated on H7), but support might be extended in future. Having pins already available would be a good start. This is the way we're proceeding in general.

erwango avatar May 13 '24 12:05 erwango

Hi, @erwango.

I have two questions about the files generated after run the Python script:

  1. Do I have to add also the new dtsi files related to STM32H523, STM32H533, STM32H7R, and STM32H7s families? Those files are totally new.
  2. I noticed that in stm32h725iekx-pinctrl.dtsi, stm32h725igkx-pinctrl.dtsi, stm32h730ibkxq-pinctrl.dtsi, and stm32h735igkx-pinctrl.dtsi files, the adc3_inp16_ph5 was removed. Do I have to accept this modification? I'll check if something similar happens with other files.

CharlesDias avatar May 16 '24 18:05 CharlesDias

Thanks for raising this @CharlesDias. This probably comes from the fact that you're generating from a latest version of open_pin_data repo. 2 options:

  • Keep working with this commit, but then do it in 2 passes: first new batch from the new version w/o dcmi files, then add the new pinctrl, generate once again and provide the new signals in a 3 commit. In this case, don't forget to update commit used in https://github.com/zephyrproject-rtos/hal_stm32/blob/main/dts/README.rst (or maybe it is done automatically)
  • Generate from SHA1 version provided in https://github.com/zephyrproject-rtos/hal_stm32/blob/main/dts/README.rst. And let the open_pin_data update aside for now.

erwango avatar May 17 '24 06:05 erwango

Hi, @erwango.

I choose the second option. ;-)

CharlesDias avatar May 17 '24 17:05 CharlesDias

This is fine for me now, but please update the first commit title to remove H7 reference, as pr is stm32 generic now.

erwango avatar May 20 '24 06:05 erwango

This is fine for me now, but please update the first commit title to remove H7 reference, as pr is stm32 generic now.

Ping @CharlesDias. I'm queuing https://github.com/zephyrproject-rtos/hal_stm32/pull/210

erwango avatar May 23 '24 13:05 erwango

This is fine for me now, but please update the first commit title to remove H7 reference, as pr is stm32 generic now.

Hi, @erwango.

Done!

CharlesDias avatar May 23 '24 16:05 CharlesDias