zed icon indicating copy to clipboard operation
zed copied to clipboard

New keybindings for VSCode

Open EvanZhouDev opened this issue 1 year ago • 2 comments

Release Notes:

  • Changed Alt+Up/Down from selecting larger/smaller syntax nodes to moving line up/down. This is the default behavior from VSCode, which is what the JSON section is labeled as.
  • Added Alt+Shift+Up/Down as duplicating lines up/down, as this is also the default VSCode behavior. These key bindings were also unused previously, so this is simply an addition.

EvanZhouDev avatar Mar 03 '24 02:03 EvanZhouDev

Could you propose a different keybinding for select larger/smaller syntax node which this PR removes?

Personally I'm not a fan of this change. I think Zed should maintain its own out-of-the-box flavour, but I see the VS Code binding is the default one. I'd propose to create a new VS Code keybinding file, but that would hinder first timers experience and discoverability.

fdionisi avatar Mar 03 '24 16:03 fdionisi

Is there any key bind that you prefer? it would appear all reasonable keybinds with an Up/Down arrow have been taken in this circumstance...

EvanZhouDev avatar Mar 03 '24 21:03 EvanZhouDev

See also here: https://github.com/zed-industries/zed/pull/8584 And especially this discussion: https://github.com/zed-industries/zed/pull/8584#issuecomment-1974306243

mrnugget avatar Mar 04 '24 08:03 mrnugget

Hey! Let's continue discussion about this in #8584, which I just reopened, since it's the older of the two PRs. @EvanZhouDev can you leave your thoughts over there as well? And thank you for opening the PR, appreciate it.

mrnugget avatar Mar 04 '24 11:03 mrnugget