zed

zed copied to clipboard

Check for existing issues

• [X] Completed

Describe the feature

When I open a new terminal, the status bar is still present at the top, taking up a bunch of space.

It would be nice if it could be removed in Terminal panes or if there was a setting to hide it for terminal panes.

If applicable, add mockups / screenshots to help present your vision of the feature

This feels like it should disappear when you turn off the breadcrumbs but it doesn't.

I tried disabling breadcrumbs. I can confirm that the empty space still appears in terminal panes.

It was probably just missed in:

• https://github.com/zed-industries/zed/pull/7338

@alygin, what do you think should happen here?

@IroncladDev, What Zed version do you use? What happens when you open the search panel in the terminal window with cmd+f?

I believe I'm on the latest stable version (0.123.6).

When I use cmd+f, it opens the search but inserts it underneath that space.

The toolbar/breadcrumbs setting, added in the mentioned PR, doesn't affect "breadcrumbs" in the terminal windows placed in the editor pane, that's true.

@IroncladDev, I think you see an empty toolbar because your PROMPT_COMMAND variable/function returns the empty value. You can try switching to bash in a terminal with an empty toolbar, and running something like this:

PROMPT_COMMAND="echo -ne \"\033]0;Here's my title\007\""

and you'll see the title in the breadcrumbs panel.

I guess, we have two options here:

1. Make the existing toolbar/breadcrumbs setting also affect the terminal title. Good: since only terminals that are placed in the editor area are affected, the editor's setting may fit better here. Bad: for the terminal it's actually not "breadcrumbs", it's the title or prompt; if something terminal-specific will be added to the toolbar later, the settings will become a mess.

2. Add another setting terminal/toolbar/title that would specifically work with the terminal's title. Good: a proper separation of the editor and the terminal settings. Bad: it may be misleading because the terminals in the bottom pane will not be affected by this setting (though it could be mentioned in the docs but it still looks a bit inconsistent).

I prefer the second option, so here's the impelemntation. But I don't mind throwing it away for a better alternative.

@SomeoneToIgnore, @JosephTLyons, what do you think is the right way? Maybe there're other options?

I ended up merging that PR, thank you for the proposals list — I liked it also among the alternatives, and seems that other people agreed too.