concrete

concrete copied to clipboard

I fixed broken file path of "Execution/Analysis"

@yuxizama , apparently we have broken path for Execution/Analysis Should we take this external commit?

@bcm-at-zama It looks good to me, the fix is correct. I think we can take it.

Thanks @yuxizama @aquint-zama , do we have the signed CLA for @sukrucildirr please?

And then we'll have the commit message fixed

Thanks @yuxizama @aquint-zama , do we have the signed CLA for @sukrucildirr please?

I had signed CLA.

@aquint-zama , do we have the signed CLA for @sukrucildirr please?

Yes that's why cla-bot already labeled this PR with cla-signed label

ok thx. So @sukrucildirr , could you reword your commit message please, to follow our rules? it could be eg

fix(compiler): fixing a broken path

Then, we'll have the CI green. Thanks

ok thx. So @sukrucildirr , could you reword your commit message please, to follow our rules? it could be eg

fix(compiler): fixing a broken path

Then, we'll have the CI green. Thanks

I did. Thanks.

The CI is still red.

You can see

Run gsactions/commit-message-checker@v1
Checking commit messages against "^(feat|fix|test|bench|docs|chore|refactor|perf)\((compiler|backend|frontend|optimizer|tools|ci|common).*\):"...
- failed: "Update README.md"
Error: Error: Your first line has to contain a commit type and scope like "feat(my_feature): msg".

and indeed, your commit message is still "Update README.md". Could you retry the rewording, please?

The CI is still red.

You can see

Run gsactions/commit-message-checker@v1
Checking commit messages against "^(feat|fix|test|bench|docs|chore|refactor|perf)\((compiler|backend|frontend|optimizer|tools|ci|common).*\):"...
- failed: "Update README.md"
Error: Error: Your first line has to contain a commit type and scope like "feat(my_feature): msg".

and indeed, your commit message is still "Update README.md". Could you retry the rewording, please?

Sorry, my misunderstand. I reword it.

Thx, running the full CI

Hum, we stil have some red CI here (not your fault @sukrucildirr). Let us check

@BourgerieQuentin , do you know what

0s Run actions/checkout@v3 with: fetch-depth: 0 repository: zama-ai/concrete ssh-strict: true persist-credentials: true clean: true sparse-checkout-cone-mode: true fetch-tags: false lfs: false submodules: false set-safe-directory: true Error: Input required and not supplied: token

is about?

Hum, we stil have some red CI here (not your fault @sukrucildirr). Let us check

@BourgerieQuentin , do you know what

0s Run actions/checkout@v3 with: fetch-depth: 0 repository: zama-ai/concrete ssh-strict: true persist-credentials: true clean: true sparse-checkout-cone-mode: true fetch-tags: false lfs: false submodules: false set-safe-directory: true Error: Input required and not supplied: token

is about?

Yes I see why is doesn't work, I'll make a PR later. The whole CI not need to be run for this PR.