yii2 icon indicating copy to clipboard operation
yii2 copied to clipboard
verified publisher icon yiisoft

Fix `CallbackDependency`

Open rob006 opened this issue 1 year ago • 3 comments

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Fixed issues

rob006 avatar May 15 '24 07:05 rob006

Why is the test green in the original commit and with your fix?

https://github.com/yiisoft/yii2/commit/8861f7bd9daf66cf7db7edaeefc236e71685273e#diff-57a96cab3e08c948305d1fb793933cfea989debf497119b97fd39b477a4706ad

schmunk42 avatar May 15 '24 08:05 schmunk42

Sorry, forget it.

Just noticed that only unit tests (build) were failing https://github.com/yiisoft/yii2/actions/runs/8676707548

schmunk42 avatar May 15 '24 08:05 schmunk42

Wow. Any idea when it was broken?

samdark avatar May 15 '24 19:05 samdark

Do we need a CHANGELOG for this one?

samdark avatar May 16 '24 09:05 samdark

This bug was never released, since CallbackDependency was added in this state in https://github.com/yiisoft/yii2/pull/20137

rob006 avatar May 16 '24 09:05 rob006

Alright. Thank you!

samdark avatar May 16 '24 09:05 samdark

@samdark this one of the reason because i used return call_user_func($this->callback) in original commit in my PR https://github.com/yiisoft/yii2/pull/20137

laxity7 avatar May 16 '24 20:05 laxity7