user icon indicating copy to clipboard operation
user copied to clipboard

Published 20 hours ago • verified publisher icon yiisoft

Use guest identity instead of nulls

Open xepozz opened this issue 2 years ago • 3 comments

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ✔️

xepozz avatar Apr 07 '23 18:04 xepozz

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.09 :warning:

Comparison is base (427a5ab) 88.44% compared to head (47713d9) 88.36%.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master      #73      +/-   ##
============================================
- Coverage     88.44%   88.36%   -0.09%     
+ Complexity       95       93       -2     
============================================
  Files            13       13              
  Lines           277      275       -2     
============================================
- Hits            245      243       -2     
  Misses           32       32
Impacted Files Coverage Δ
src/CurrentUser.php 100.00% <100.00%> (ø)
src/UserAuth.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 07 '23 18:04 codecov[bot]

Overall the change looks OK. Need a CHANGELOG for it.

Also, it's is backwards compatibility breaking one.

samdark avatar Jun 30 '23 16:06 samdark

It shouldn't be merged yet because it cause bugs in authentication.

xepozz avatar Jul 01 '23 13:07 xepozz