sublime-go icon indicating copy to clipboard operation
sublime-go copied to clipboard

gopls support?

Open jostyee opened this issue 6 years ago • 8 comments

I was told that guru would be replaced by gopls in the near future.

jostyee avatar Aug 19 '19 04:08 jostyee

I did try and use it a few months ago, it seemed like it is still incomplete. If it supports all the features this plugin has, I'll definitely move to gopls.

yields avatar Aug 19 '19 09:08 yields

But guru won't support go mod, see: https://github.com/golang/go/issues/31720#issuecomment-495722369

jostyee avatar Aug 19 '19 10:08 jostyee

hmm, that's odd, IIRC it does support it easily, for example I just ran Go: source command on require.New(), It took me to:

'/Users/amir/dev/pkg/mod/github.com/stretchr/[email protected]/require/forward_requirements.go'

Have you tried it?

yields avatar Aug 19 '19 10:08 yields

No, I've switched to LSP before.

As the official track issue https://github.com/golang/go/issues/24661 showed, guru actually doesn't support mod, and has been tagged as deprecated: https://github.com/golang/go/issues/24661#issuecomment-492478653

jostyee avatar Aug 19 '19 10:08 jostyee

odd stuff, it definitely supports it, and always takes me to a module (.../pkg/mod/...) when go.mod exists.

I'll keep this issue open, eventually I would like to move to gopls either way if this plugin needs extra features we can keep using individual go tools as needed.

yields avatar Aug 19 '19 10:08 yields

Please feel free to file issues in the issue tracker that you feel incomplete with gopls, so that it can be tracked and worked on. gopls is going to be the sole interface for all editor integration in the future. So we definitely need to be looking into gopls integration.

agnivade avatar Aug 19 '19 18:08 agnivade

FYI, I've been using tabnine ST plugin for months and find it's really promising, meanwhile gopls always has autocomplete issues on my vscode.

jostyee avatar Aug 20 '19 11:08 jostyee

Don't get me wrong, but why you would like support gopls, while it is actually supported via https://github.com/tomv564/LSP Also if there isn't working something correctly related to gopls, won't be better to contribute to the LSP-related package directly? I see it as a waste of time and energy that could be invested into developing more interesting features.

piotrkubisa avatar Nov 13 '19 16:11 piotrkubisa