react-flickity-component icon indicating copy to clipboard operation
react-flickity-component copied to clipboard

Published 20 hours ago • verified publisher icon yaodingyd

Updating peer dependencies to support React v. 18

Open haase1020 opened this issue 3 years ago • 4 comments

First of all, thank you for this package! I would like to continue using react-flickity-component in my project, but I am getting an error about an incorrect peer dependency when I try to upgrade to React v. 18. Is it possible to update peer dependencies to support React v. 18? I am more than happy to help in any way I can!

haase1020 avatar Apr 25 '22 01:04 haase1020

PR is welcome. Could you also verify it is working with react 18?

yaodingyd avatar Apr 25 '22 02:04 yaodingyd

Sounds good! I will submit a PR as soon as I verify that the code works with react 18.

haase1020 avatar Apr 26 '22 08:04 haase1020

+1 for this 👍

At first glance, it seems my issue is to do with React no longer including children in the default component props, so would need to integrate PropsWithChildren.

nathnhughes avatar May 12 '22 10:05 nathnhughes

Works in some days... Now, the error with react 18 persists again.

PQPMath3ws avatar Jun 11 '22 04:06 PQPMath3ws

Ditto

j2is avatar Oct 24 '22 11:10 j2is

npm refuses to install react-flickity-component, but yarn installs it, with error tho image

It works perfectly with react > 18

bogdanbryzh avatar Oct 27 '22 00:10 bogdanbryzh

Here's working app example https://showcase-rfc-with-react-18.vercel.app/ And repo https://github.com/bogdanbpeterson/showcase-rfc-with-react-18

bogdanbryzh avatar Oct 27 '22 00:10 bogdanbryzh

Is there any news o this? i would like to use this package with react 18 🙂

ogaguinaga avatar Oct 30 '22 03:10 ogaguinaga

Is there any news o this? i would like to use this package with react 18 🙂

You can, install it with yarn, but it's not safe (haha, it's obvious, isn't it? 😂)

bogdanbryzh avatar Oct 30 '22 03:10 bogdanbryzh

yeah... 😅 I meant more about this issue being merged and released

ogaguinaga avatar Oct 30 '22 03:10 ogaguinaga

PR welcome

yaodingyd avatar Oct 31 '22 14:10 yaodingyd

@bogdanbpeterson looks like your example is working great with React 18 — you could PR the changes that you made? Looking forward to using this with Next.js 13, as their minimum React version is 18.

cooperwfloyd avatar Nov 04 '22 15:11 cooperwfloyd

@cooperwfloyd I changed literally nothing, just installed it using yarn instead of npm. I don't even know what to change to create a PR 😅

bogdanbryzh avatar Nov 04 '22 16:11 bogdanbryzh

Haha 😆 well thanks for the quick reply @bogdanbpeterson. My guess is that it is a conflict with the newer Node / NPM versions and how they check peer dependencies then. Thanks for the info 👍

cooperwfloyd avatar Nov 04 '22 18:11 cooperwfloyd

is there any news on this PR?

ogaguinaga avatar Nov 14 '22 23:11 ogaguinaga

Is there a reason why this is not moving anywhere? I would love to use this 😅 anything I can do to help and accelerate this process?

ogaguinaga avatar Nov 22 '22 20:11 ogaguinaga

@ogaguinaga someone just needs to PR the changes to make this library compatible with React 18 and recent Node versions without the use of --legacy-peer-deps during installation. If you want to move this forward and have the time you are welcome to PR those changes 👍

cooperwfloyd avatar Nov 23 '22 17:11 cooperwfloyd

v4.0.0 is released with react 18 support.

yaodingyd avatar Dec 14 '22 23:12 yaodingyd

yay, good news 🥳

bogdanbryzh avatar Dec 14 '22 23:12 bogdanbryzh

amazing! thank you so much @yaodingyd! fully ready now to make the upgrade to Next.js 13 💪

cooperwfloyd avatar Dec 14 '22 23:12 cooperwfloyd