Yann Simon

Results 170 comments of Yann Simon

@davidpdrsn this is the PR fixing the warnings emitted by clippy.

@davidpdrsn reminder to review this PR 😉

I have not seen any overflow, so I think we're safe here. What I can observe on production: when we use this change + https://github.com/davidpdrsn/assert-json-diff/pull/30, then the server consumes much...

> Hm I wouldn't expect recursion to impact memory usage that much. Have you tried it with just #30? No I have not. This would take some time. Do you...

> > No I have not. This would take some time. Do you need that? > > Yes. I don't think we refactor the code without a good reason as...

`cargo clippy` is failing for parts of the code that were not touched by this PR. If you want, I can open a new PR for that.

https://github.com/davidpdrsn/assert-json-diff/pull/32

Thx for positive feedback! ❤️ Yes I can guess this feature would change quite a lot and would take some time.

@thebrenthaines It'd be great to share your knowledge with us. For example, have you used a `ChunkedWriteHandler` instead of the default `HttpObjectAggregator`?

> 1. The `SynchronizedMap` here is used for tracking fibers for the new "fiber dump" feature introduced in 3.3.0. So, the easiest way to remove this overhead is simply to...