macos-defaults icon indicating copy to clipboard operation
macos-defaults copied to clipboard

Add Finder's NewWindowTarget option

Open amomchilov opened this issue 3 years ago • 4 comments

TODO:

Can somebody please check what values are set when the chosen option is "iCloud Drive" (it's disabled on my machine, so I can't check it myself)

I checked it with:

defaults read com.apple.Finder > before.txt
# Make the change, and try the next line a few times until the setting is persisted:
defaults read com.apple.Finder > after.txt ; git diff before.txt after.txt

rm before.txt after.txt

amomchilov avatar Feb 09 '22 17:02 amomchilov

I had an indentation error. I've fixed it. Could you retry the CI and merge this if it's good? :)

amomchilov avatar Feb 15 '22 17:02 amomchilov

Oh, looks like the examples are mandatory. Should they be?

amomchilov avatar Feb 15 '22 17:02 amomchilov

The fact that we need 2 commands to change this settings breaks the architecture of the project which assumed 1 command was always sufficient. I will adapt the project architecture to be able to create these kind of complex commands.

Thanks a lot for this PR anyways, I'll update it to merge when the project is ready.

yannbertrand avatar Aug 16 '22 09:08 yannbertrand