s3-concat icon indicating copy to clipboard operation
s3-concat copied to clipboard

feature request: add support for NDJSON, log message to pushed s3 key & compression

Open diman82 opened this issue 2 years ago • 0 comments

Hi @xtream1101

Please add support for:

  1. NDJSON format (basically adding a new-line separator), e.g.
def construct_jsonl_str(items) -> str:
    json_str = ''
    for item in items:
        json_str += json.dumps(item) + os.linesep  # added workaround to convert to NDJSON
    return json_str
  1. log message with s3 key to be put (probably somewhere here)

  2. Please add compression to concatenated file

P.S I can contribute the requestd above logic by myself, if possible

diman82 avatar May 16 '23 15:05 diman82