xterm.js
xterm.js copied to clipboard
xtermjs
IME: Electron 13: text not visible on Windows while composition is in progress
Likely related to #3679, the characters typed into the IME are not shown in xterm until composition is complete - but works in Chrome.
Not sure what to do about this one though - looking at the event traces, it's due to the missing compositionupdate events. I'm very reluctant to "just" emulate them - not sure what else will get broken by this.
I think VS Code is upgrading Electron in this version. If it's specifically related to electron 13 maybe we should not support it?
What's weird is that VSCode terminal already doesn't work for me in the stable release since it runs on 13.5.2. I'm starting to suspect it might be related to my machine since there isn't anything in vscode issues atm.
I'll try bisecting electron releases to figure out when exactly it broke.
It's specifically v12.0.9 and v13.1.7 that stopped working (haven't bisected later major releases, and don't need to) - the only overlap between the two is this commit: https://github.com/electron/electron/commit/2e096ac6bc91fd25b1f500d815a5e945314a3d64, which is about... window focus management? I can only fathom how this can be related to IME handling.