go-xmpp

go-xmpp copied to clipboard

@fredipevcin: Why have you closed your PR?

Jan 28 '20 14:01 Neustradamus

@Neustradamus: because there were no activity.

Jan 29 '20 07:01 fredipevcin

@mattn: What do you think about this PR?

Mar 01 '23 23:03 Neustradamus

Could you please fix conflict?

Mar 02 '23 06:03 mattn

@fredipevcin: Have you seen the @mattn comment?

Nov 01 '23 19:11 Neustradamus

Could you please fix conflict?

Nov 11 '23 12:11 mattn

Hey, I will try to fix this as soon as possible (week or 2). You are welcome to do it otherwise I will when time allows me.

Nov 20 '23 11:11 fredipevcin

Had an issue with tests.. so I removed them. If you have a suggestion how to add them, let me know.

Another thing I noticed during the testing. If server respond with multiple mechanism then the first one will be selected (PLAIN). Not sure if this is good thing.

<stream:stream xmlns='jabber:client'
	   xmlns:stream='http://etherx.jabber.org/streams'
	   to='domain'
	   version='1.0'>
	<stream:features>
		<mechanisms xmlns='urn:ietf:params:xml:ns:xmpp-sasl'>
			<mechanism>PLAIN</mechanism>
			<mechanism>X-OAUTH2</mechanism>
		</mechanisms>
	</stream:features>

Nov 24 '23 12:11 fredipevcin

@Neustradamus @mattn If this is good enough for you you can merge it. It's been a long time since I use this. I can't even test it.

Nov 24 '23 13:11 fredipevcin

It should prefer SCRAM mechanisms over PLAIN. If you want to use OAUTH or EXTERNAL I guess you'll tell the lib to do so by the setting.

I have no idea about tests. Maybe @mattn knows more.

Am 24. November 2023 12:59:01 UTC schrieb Fredi Pevcin @.***>:

Had an issue with tests.. so I removed them. If you have a suggestion how to add them, let me know.

Another thing I noticed during the testing. If server respond with multiple mechanism then the first one will be selected (PLAIN). Not sure if this is good thing.

<stream:stream xmlns='jabber:client'
     xmlns:stream='http://etherx.jabber.org/streams'
     to='domain'
     version='1.0'>
  <stream:features>
  	<mechanisms xmlns='urn:ietf:params:xml:ns:xmpp-sasl'>
  		<mechanism>PLAIN</mechanism>
  		<mechanism>X-OAUTH2</mechanism>
  	</mechanisms>
  </stream:features>

Nov 24 '23 13:11 mdosch

@fredipevcin: Have you seen the @mdosch comment?

Dec 06 '23 01:12 Neustradamus

@fredipevcin: What is your email address?

Dec 26 '23 16:12 Neustradamus

@fredipevcin I also don't have a server using external authentication and am therfore also unable to test it. :(

Jan 08 '24 19:01 mdosch

@fredipevcin: Have you seen the @mdosch comments?

Oct 05 '24 17:10 Neustradamus

@Neustradamus I've seen. I suggest to close this PR because it's 6 years old and I'will not resolve conflicts again. If someone has time to implement this, please do.

Oct 07 '24 10:10 fredipevcin