xmo-odoo

> Hello odoo/rd-security I believe phenix-factory has made all the requested changes, is there anything else to bypass the ci? I still don't see why two requests are necessary, and...

Q: this seems to remove the longpoling route entirely, does the new websocket code still leverage gevent or not?

> Yes it does, else we would have 1 thread per opened websocket which is not viable. Probably needs an documentation PR to explain how the new configuration works then....

@robodoo override=ci/security sha1 = required websocket header, defined as base64(sha1(key + specific guid) getattr = optional (or is it?) thread metadata resolve_attr = collision with an import list being updated

@robodoo r- See: https://runbot.odoo.com/runbot/batch/854030 Not sure why it didn't fire on the PR, but it seems to fire very reliably in staging, asked in runbot discord.

There's also a bpo issue on that subject: https://bugs.python.org/issue42106 It provides more examples from the Python documentation > For instance if you search "append": https://docs.python.org/3/search.html?q=append > > On my end,...

I've hit a similar issue trying to create a database in an `execute` then getting quite flummoxed when I couldn't find my tables, had no errors and it worked fine...

> **f-strings** don't fit in here, since they are [not backward-compatible](https://www.python.org/dev/peps/pep-0498/#id47). OTOH there are suggestions to add notes about `format_map` in other issues and @ulope seems broadly favorable, so the...

That seems to correspond to / overlap with #44

I don't know that the split even makes sense, fundamentally the first section is already using keyword arguments: `%` uses dicts for named placeholders while `format` uses keyword arguments (though...