vue-google-maps

vue-google-maps copied to clipboard

Hi,

I'm thinking about using this lib in production. However, 200+ issues is not the best introduction to a library.

Is this project still alive? Or should I consider one of the other options?

Whats your take guys?

Cheers

Hi Linus,

Thanks for asking. I'm not available to actively maintain the project. Patches are still welcome. Partly also because I'm mostly using MapboxGL at work instead of Google Maps.

What's urgently needed are:

1. Better automated tests
2. Better integration tests with the popular frameworks, especially Nuxt and Vue template
3. Better documentation (examples, recommendations)

The above three will go a long way to keeping the project maintainable and contributable, and will address many of the open issues.

I guess as the project owner, I should have made these things a priority. Still, I'm somewhat daunted by the challenge of 2) -- I've no idea how best to spin up a Nuxt project as an automated test and ensure that it works in dev, ssr and spa mode --, and 3) just requires a lot of time. Do you have ideas on how to write good documentation? With live code examples?

Part of why it's hard to maintain this project is the absence of good integration tests. Which means that every change has to be accompanied by tedious manual tests. Yet every so often, I accidentally break something in release. All this raises the barriers to entry to any change or patch. This something I'm afraid I don't have too much time for.

That said, barring major changes to the Google Maps JS API, there will be little need to change most parts of the code. Additional properties and events can be supported with just few additional lines of code to the glue.

On Tue, 23 Oct 2018, 21:59 Linus <[email protected] wrote:

Hi,

I'm thinking about using this lib in production. However, 200+ issues is not the best introduction to a library.

Is this project still alive? Or should I consider one of the other options?

Whats your take guys?

Cheers

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/xkjyeah/vue-google-maps/issues/514, or mute the thread https://github.com/notifications/unsubscribe-auth/ACiTR-2BIDFsvflRBczWZ6lM6gpfaaFlks5unyDfgaJpZM4X1o3c .

@xkjyeah Brother, look at the weekly npm downloads. So many projects are using this.

I would recommend you to put a bold notice above the readme for contribution. I don't understand test cases, so can't help with that. But I can help with the documentation.

@devWaleed yes i fully understand that the project is widely used. but I'll have to selfishly admit that, if I'm not using it at work, I've very little incentive to bear the pain from my RSI in order to save other projects.

Do you think you can do some documentation with VuePress?

@xkjyeah we use this repo in production on two sites. I think documentation with VuePress is a great idea. I'll get a repo started and a site up for it

Thank you for such a great response. Trying to keep this repo community-driven is the best way to go.

WIP Docs are live here: https://condescending-lovelace-65c715.netlify.com/

Repo here: https://github.com/beardedpayton/vue-google-maps-docs

imo I think it is fine you have provided us with a free service.

If you want to use this in production to generate income I think its your job to ensure your code is up to scratch not some random guy on the internet who did something for free.

@noobling For sure. I was just checking my alternatives. I went with my own solution instead as the libraries I found wasn't up to the standards I want. It's always my job to make sure the code I ship is up to par. That's why I reviewed this library and many others 👍

Hey :wave: Nuxt core team member here.

first of all, thanks for your work and efforts :clap:

I've created an example project here with Nuxt 2 + vue2-google-maps.

Automated testing is possible too, an example can be found in any of my nuxt module repositories (eg here). I won't have the time to help with actual code though :slightly_frowning_face:

But feel free to drop me a message via Discord (the Nuxt.js one or VueLand) if you need further help, I'm quite active there.

@manniL Thanks! I've added a link (maybe it's too nondescript?) to the README. Hopefully that helps!

Vue.js core team member @akryum is building the same set of components. Wouldn't it be better to converge efforts in one library? https://github.com/Akryum/vue-googlemaps

Hi, is someone actually reviewing the opened PRs or granting permissions to merge it? This project is good but it needs more work, if anyone can give me permission on this repo I am willing to do that. Regards

granting permissions to merge

This would be a big help, if somebody trustworthy would volunteer to have higher privileges for this repo. I'd hate to see a multitude of competing forks of this project because contributors do not have simple write access.

I'm happy to grant access. But somebody must ask for it first.

On Fri, 14 Jun 2019, 09:42 Damien Bezborodow, [email protected] wrote:

granting permissions to merge

This would be a big help, if somebody trustworthy would volunteer to have higher privileges for this repo. I'd hate to see a multitude of competing forks of this project because contributors do not have simple write access.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/xkjyeah/vue-google-maps/issues/514?email_source=notifications&email_token=AAUJGR7GD42XOTRRQAJZO3LP2LZRZA5CNFSM4F6WRXOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXVPGSY#issuecomment-501936971, or mute the thread https://github.com/notifications/unsubscribe-auth/AAUJGR6QKUS4I3LV42FFGCDP2LZRZANCNFSM4F6WRXOA .

I like to have access to review and merge PRs in this repository if you are in agreement.

Just take care on who gets the permissions we don’t want another flatmap to occur.

https://snyk.io/blog/malicious-code-found-in-npm-package-event-stream/

I use this package in my code, but you have reason @noobling. If you want, take a look on my repos. You decides.

@diegoazh I've granted npm access :)

I'd prefer to see access granted to people who have contributed in the past (or who even have pull requests open) rather than strangers without any commit history for this project.

@bezborodow I would like to contribute with this project manteining it, but I don't like to be the only one. It will be great that others contributors will have access too, because other oppinions are always welcome.

Hm... alright I'll compromise -- i'll retain npm rights, but I'll let diego (or any other volunteers) accept PRs.

Does that seem reasonable?

Yes, it's right for me.

@JeremiahPinto we should consider maintaining the tools we use for @codersforcauses

Happy to throw my hat into the ring and help maintain things here. I've used this project multiple times in the past and don't want to see it die off.

Hello, is there any good starting point for adding test cases to the project? I'm a newbie when it comes to front-end development and open-source contributing but I'm going to start using gmaps in production and it would benefit both the project and myself to start contributing.

Hey,

Thanks for the interest in contributing!

I don't have a good solution for testing here. Roughly speaking, I imagine a solution would involve:

• running the tests in a fake browser (e.g. headless chrome)
• mocking google.maps.* objects to some degree of fidelity
• or (bad) loading google.maps.* objects with an API key for testing -- however this makes assertions hard (e.g. asserting that a map is created when new Map() is called)

In short, the space is open for you to experiment. Feel free to dump the existing tests.

On Wed, 2 Oct 2019, 17:22 Terry Finkel, [email protected] wrote:

Hello, is there any good starting point for adding test cases to the project? I'm a newbie when it comes to front-end development and open-source contributing but I'm going to start using gmaps in production and it would benefit both the project and myself to start contributing.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/xkjyeah/vue-google-maps/issues/514?email_source=notifications&email_token=AAUJGR7OWA5BMGG23VL35H3QMRR57A5CNFSM4F6WRXOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAED7NY#issuecomment-537411511, or mute the thread https://github.com/notifications/unsubscribe-auth/AAUJGR3XC4L6UQQEH3PVDNTQMRR57ANCNFSM4F6WRXOA .

WIP Docs are live here: https://condescending-lovelace-65c715.netlify.com/

Repo here: https://github.com/beardedpayton/vue-google-maps-docs

Not found

What is the current status of this project?

@tstrohmeier The last commit was on February 3rd so definitely not dead.

No, but the owner did not land a new version, I don't know why 🤷