libandroidjni icon indicating copy to clipboard operation
libandroidjni copied to clipboard

Published 20 hours ago • verified publisher icon xbmc

PlaybackState: Enable Actions

Open fritsch opened this issue 1 year ago • 5 comments

We should properly identify the actions of the media session as well, cause SetActions needs them.

fritsch avatar Apr 13 '24 16:04 fritsch

You also have to enable these constants in the header file

joseluismarti avatar Apr 15 '24 09:04 joseluismarti

You also have to enable these constants in the header file

Oh indeed my bad, didn’t think about that. Thx for the catch!! edit: Do we really need to, though? Seems they are just defined in the cpp file to avoid clashes with some core macros? See: https://github.com/xbmc/libandroidjni/blob/e9ed53277aca16ce9089dbc69acc1a151f73aeea/src/PlaybackState.h#L31

a1rwulf avatar Apr 15 '24 09:04 a1rwulf

In order to be used from other classes they need to be in the header. There should be no conflict if used in this way: CJNIPlaybackState::ACTION_PLAY

joseluismarti avatar Apr 15 '24 10:04 joseluismarti

You also have to enable these constants in the header file

Thanks git add for the win ;-)

fritsch avatar Apr 15 '24 13:04 fritsch

Let's keep it open for a bit - I want to fix the other bug for the MediaSession first and time is very limited.

fritsch avatar Apr 15 '24 13:04 fritsch