Xamarin.Forms icon indicating copy to clipboard operation
Xamarin.Forms copied to clipboard

Published 20 hours ago • verified publisher icon xamarin

[Core] Make BindableLayout handle collection changed on the main thread

Open GalaxiaGuy opened this issue 4 years ago • 4 comments

Description of Change

Changes the BindableLayout.ItemsSourceCollectionChanged method to handle changes on the main thread.

Issues Resolved

  • fixes #14039

API Changes

None

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

There are unit tests that just confirm that BeginInvokeOnMainThread is called.

PR Checklist

  • [ ] Targets the correct branch
  • [ ] Tests are passing (or failures are unrelated)

GalaxiaGuy avatar Oct 26 '21 21:10 GalaxiaGuy

/azp run

jfversluis avatar Oct 27 '21 12:10 jfversluis

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 27 '21 12:10 azure-pipelines[bot]

@hartez What do you think, would you have any objection to this change?

jsuarezruiz avatar Nov 08 '21 09:11 jsuarezruiz

@jfversluis Any chance that this one is making it into a Xamarin.Forms service release?

thisisthekap avatar Jan 18 '24 10:01 thisisthekap

Now that we're so close to the sunsetting of Xamarin.Forms unfortunately we won't be able to take this in anymore, we're really sorry about that. Nevertheless, thank you so much for your time and effort that you have put into this PR.

Please have a look at the evolution of Xamarin.Forms, .NET MAUI. A lot of development has been going on there. Hopefully this issue was already fixed in that codebase. If not, feel free to port this over to there.

Again, thank you so much for being a contributor and Xamarin.Forms user!

jfversluis avatar Apr 25 '24 08:04 jfversluis