Xamarin.Forms icon indicating copy to clipboard operation
Xamarin.Forms copied to clipboard

Published 20 hours ago • verified publisher icon xamarin

[Android] SwipeView used in a CollectionView fires the SelectionChangedCommand unintentionally

Open jsuarezruiz opened this issue 4 years ago • 6 comments

Description of Change

Avoid fire the CollectionView SelectionChangedCommand event if the user tap a Button for example. With the change from this PR, the behavior is the same the behavior as without using SwipeView.

Issues Resolved

  • fixes #11982

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Before

issue11982

After

fix11982

Testing Procedure

Launch Core Gallery and navigate to the issue 11982. In the CollectionView using the SwipeView, tap the Button. If not trigger the SelectionChanged, the test has passed.

PR Checklist

  • [ ] Targets the correct branch
  • [ ] Tests are passing (or failures are unrelated)

jsuarezruiz avatar Nov 04 '20 13:11 jsuarezruiz

Added changes to fix the build error.

jsuarezruiz avatar Nov 11 '20 12:11 jsuarezruiz

Perhaps not within the scope of this PR, but what's the expected behavior on iOS? I'm seeing that it's different on iOS than on Android

Also, what's the expected behavior when clicking on the "Command" button itself? I sometimes get the dialog and I sometimes see the "-PRESSED" added on

rachelkang avatar Dec 03 '20 22:12 rachelkang

@jsuarezruiz build is failing

rmarinho avatar Dec 16 '20 23:12 rmarinho

@jsuarezruiz can we UITest this?

rmarinho avatar Dec 18 '20 10:12 rmarinho

Sure Captura de pantalla 2020-12-18 a las 18 49 03

jsuarezruiz avatar Dec 18 '20 17:12 jsuarezruiz

@rachelkang Could you try again? The behavior should be the same on Android and iOS.

jsuarezruiz avatar Dec 18 '20 18:12 jsuarezruiz

Not sure if this fix is still correct and seeing where we are in the Xamarin lifecycle, we probably won't be merging this anymore

jfversluis avatar Nov 29 '23 19:11 jfversluis