Xamarin.Forms
Xamarin.Forms copied to clipboard
xamarin
fix: Button on ListView should not pass click to listview when disabled
Issues Resolved
fixes #8763
Platforms Affected
- iOS
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist
- [] Targets the correct branch
- [] Tests are passing (or failures are unrelated)
@l4nk4b3l Could you include a sample (and maybe a UITest) where validate the issue and the fix?. Let me know if you need help with something.
@jsuarezruiz Is the a guide on how to write a uitest ? Are there sample tests ? I don't know where to start.
The sample should be added here: https://github.com/xamarin/Xamarin.Forms/tree/5.0.0/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared About UITest: https://docs.microsoft.com/en-us/appcenter/test-cloud/frameworks/uitest/cheatsheet Can find many samples in the gallery, but if need anything or you feel blocked let me know and I can create it and share with you.
Thank you! The additional information was enough so i could add a uitest to proof this issue has been fixed.
I would like to know whats going on. I requested review about 6 months ago.
@jfversluis Any chance that this one is making it into a Xamarin.Forms service release?
Now that we're so close to the sunsetting of Xamarin.Forms unfortunately we won't be able to take this in anymore, we're really sorry about that. Nevertheless, thank you so much for your time and effort that you have put into this PR.
Please have a look at the evolution of Xamarin.Forms, .NET MAUI. A lot of development has been going on there. Hopefully this issue was already fixed in that codebase. If not, feel free to port this over to there.
Again, thank you so much for being a contributor and Xamarin.Forms user!
