Essentials icon indicating copy to clipboard operation
Essentials copied to clipboard

Published 20 hours ago • verified publisher icon xamarin

added contact phone number type and default (android only so far)

Open philipag opened this issue 3 years ago • 2 comments

Description of Change

Added additional Contact meta data for phone number type and default (currently Android-only). It's a minor change and existing tests/samples/docs should be sufficient.

Bugs Fixed

  • Related to issue #

none

API Changes

Added:

ContactPhone.PhoneType and ContactPhone.IsDefault properties which are populated on Android.

Changed:

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

  • [ ] Has tests (if omitted, state reason in description)
  • [ ] Has samples (if omitted, state reason in description)
  • [x] Rebased on top of main at time of PR
  • [x ] Changes adhere to coding standard
  • [ ] Updated documentation (see walkthrough)

philipag avatar Apr 08 '22 05:04 philipag

CLA assistant check
All CLA requirements met.

ghost avatar Apr 08 '22 05:04 ghost

Hey there @philipag! Thanks for the PR! However, at this time we're not really looking to add new functionality into Xamarin.Essentials anymore as we're transitioning into .NET MAUI. It's probably best to open an issue there (or see if there is already one) to discuss these changes first and see to potentially implement it there.

jfversluis avatar Apr 08 '22 11:04 jfversluis